Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added global context and started example with Banner #387

Merged
merged 5 commits into from
Mar 24, 2024

Conversation

EtoKruto
Copy link
Contributor

Dev Summary

Mocks

Test Plan

repro steps:

  1. localhost:3000
  2. click X button
    expected:

Resources

@EtoKruto EtoKruto self-assigned this Nov 10, 2023
@EtoKruto
Copy link
Contributor Author

Create an global context for json text and an example for BannerSection as its the first page that comes up during testing but the rest of the text will be a large undertaking:

Template for changing text for particular page:

  1. Add section and text following the current example in /providers/MarketingTextProvider.tsx
  2. Add line import { useMarketingText } from './../providers/MarketingTextProvider';
  3. Add line const { banner } = useMarketingText(); after the the function declaration. Use a deconstructor for a cleaner consumption.
  4. Lastly, consume the text using the invocation of the section.subsection. Ex: {banner.mainHigh}

@EtoKruto EtoKruto linked an issue Nov 10, 2023 that may be closed by this pull request
Copy link
Contributor

@esteban-gs esteban-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EtoKruto EtoKruto removed their assignment Feb 16, 2024
Copy link
Contributor

@denniswangcodes denniswangcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@denniswangcodes denniswangcodes merged commit 541eef0 into main Mar 24, 2024
3 checks passed
@denniswangcodes denniswangcodes deleted the feature_291_marketing-text-context-creation branch March 24, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralize marketing materials app text into a central object in React
3 participants